-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix helm lint errors and disable version check #5068
Conversation
b992c83
to
6798a66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5068 +/- ##
=======================================
Coverage 58.98% 58.99%
=======================================
Files 645 645
Lines 55590 55590
=======================================
+ Hits 32791 32794 +3
+ Misses 20204 20202 -2
+ Partials 2595 2594 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Thanks for taking the initiative @lowc1012. I wasn't aware of the importance of tags for the release process either. |
@davidmirror-ops Closed this issue cuz addressed in #5072 |
Tracking issue
NA
Why are the changes needed?
Failed CI in validate-helm-charts.yaml workflow blocks other PRs, and I think we don't have specification for chart version with chart modifications.
What changes were proposed in this pull request?
Create KinD cluster
andct install
steps temporarily until we prepare all needed dependencies.How was this patch tested?
test on commit "7773afb"
https://github.com/lowc1012/flyte/actions/runs/8306349553
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link