Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm lint errors and disable version check #5068

Closed
wants to merge 7 commits into from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Mar 16, 2024

Tracking issue

NA

Why are the changes needed?

Failed CI in validate-helm-charts.yaml workflow blocks other PRs, and I think we don't have specification for chart version with chart modifications.

What changes were proposed in this pull request?

  1. fix lint errors
  2. disable version and maintainers check
  3. Remove Create KinD cluster and ct install steps temporarily until we prepare all needed dependencies.

How was this patch tested?

test on commit "7773afb"
https://github.com/lowc1012/flyte/actions/runs/8306349553

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 16, 2024
@lowc1012 lowc1012 force-pushed the fix-helm-ci branch 6 times, most recently from b992c83 to 6798a66 Compare March 16, 2024 07:38
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 16, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (eb24107) to head (4dff127).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5068   +/-   ##
=======================================
  Coverage   58.98%   58.99%           
=======================================
  Files         645      645           
  Lines       55590    55590           
=======================================
+ Hits        32791    32794    +3     
+ Misses      20204    20202    -2     
+ Partials     2595     2594    -1     
Flag Coverage Δ
unittests 58.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 18, 2024
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
@davidmirror-ops
Copy link
Contributor

Thanks for taking the initiative @lowc1012. I wasn't aware of the importance of tags for the release process either.
Should we close this one as duplicate?

@lowc1012
Copy link
Contributor Author

lowc1012 commented Mar 26, 2024

@davidmirror-ops
Probably we can use appVersion in Chart.yaml to tag release versions instead of comment + script.

Closed this issue cuz addressed in #5072

@lowc1012 lowc1012 closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants