Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - Bump helm chart version test #5071

Closed
wants to merge 23 commits into from

Conversation

eapolinario
Copy link
Contributor

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

neilisaur and others added 22 commits February 27, 2024 22:14
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Neil Stout <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 58.97%. Comparing base (3100c12) to head (cf594f6).
Report is 3 commits behind head on master.

Files Patch % Lines
...asks/pluginmachinery/flytek8s/k8s_resource_adds.go 28.57% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5071   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         645      645           
  Lines       55578    55590   +12     
=======================================
+ Hits        32778    32786    +8     
- Misses      20207    20209    +2     
- Partials     2593     2595    +2     
Flag Coverage Δ
unittests 58.97% <37.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants