Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[House keeping] remove setting max size bytes in node context #5092

Merged
merged 2 commits into from
Apr 19, 2024

add note for clarity

b31f638
Select commit
Loading
Failed to load commit list.
Merged

[House keeping] remove setting max size bytes in node context #5092

add note for clarity
b31f638
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 19, 2024 in 0s

58.98% (-0.02%) compared to 2db8eed

View this Pull Request on Codecov

58.98% (-0.02%) compared to 2db8eed

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 58.98%. Comparing base (2db8eed) to head (b31f638).
Report is 96 commits behind head on master.

Files Patch % Lines
...uginmachinery/ioutils/remote_file_output_reader.go 0.00% 7 Missing ⚠️
flyteplugins/go/tasks/plugins/testing/echo.go 0.00% 1 Missing ⚠️
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 0.00% 1 Missing ⚠️
...ugins/go/tasks/plugins/webapi/databricks/plugin.go 0.00% 1 Missing ⚠️
flytepropeller/pkg/controller/controller.go 0.00% 1 Missing ⚠️
...ytepropeller/pkg/controller/nodes/array/handler.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5092      +/-   ##
==========================================
- Coverage   58.99%   58.98%   -0.02%     
==========================================
  Files         645      645              
  Lines       55648    55649       +1     
==========================================
- Hits        32831    32826       -5     
- Misses      20222    20228       +6     
  Partials     2595     2595

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov