Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contribute): Change go mod tidy to make go-tidy #5131

Merged

Conversation

MortalHappiness
Copy link
Member

Tracking issue

N/A

Why are the changes needed?

It's better to run make go-tidy because it also run go mod tidy for other components.

What changes were proposed in this pull request?

Change go mod tidy to make go-tidy in the contribution guide.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.54%. Comparing base (c81133b) to head (f132af0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5131      +/-   ##
==========================================
- Coverage   59.03%   58.54%   -0.49%     
==========================================
  Files         645      567      -78     
  Lines       55726    51099    -4627     
==========================================
- Hits        32896    29916    -2980     
+ Misses      20233    18767    -1466     
+ Partials     2597     2416     -181     
Flag Coverage Δ
unittests 58.54% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett requested a review from eapolinario March 28, 2024 14:15
@neverett
Copy link
Contributor

Adding @eapolinario for code review, since this isn't strictly a docs change.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 28, 2024
@eapolinario eapolinario enabled auto-merge (squash) March 28, 2024 15:21
@eapolinario eapolinario merged commit 686ec8a into flyteorg:master Mar 28, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants