-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade lestrrat-go/jwx to v1.2.29 #5141
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5141 +/- ##
==========================================
- Coverage 60.06% 59.11% -0.96%
==========================================
Files 463 645 +182
Lines 38884 55574 +16690
==========================================
+ Hits 23357 32852 +9495
- Misses 13687 20129 +6442
- Partials 1840 2593 +753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
10e88e7
to
4fa4186
Compare
Looks like this one is going to require some test fixes
UPDATE: ran this test locally in isolation and it passed. I think there might be some shared state / test races / timing issues somewhere. |
d2d609d
to
c851a1b
Compare
Test fails are gone now in CI - think it was an unrelated intermittent fail. I've updated everything against master so I think this one is good now @eapolinario |
c851a1b
to
b27a20c
Compare
42fe6cb
to
23ad80a
Compare
b636d3c
to
8db5163
Compare
- go get -u github.com/lestrrat-go/jwx Resolves a number of vulnerabilities including: CVE-2024-28122 medium CVE-2024-21664 high CVE-2023-49290 medium CVE-2024-28122 medium Signed-off-by: ddl-ebrown <[email protected]>
8db5163
to
45d8f28
Compare
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
Resolves vulnerabilities
What changes were proposed in this pull request?
go get -u github.com/lestrrat-go/jwx
Resolves the vulnerabilities
GHSA-hj3v-m684-v259 medium
GHSA-pvcr-v8j8-j5q3 high
GHSA-7f9x-gw85-8grf medium
GHSA-hj3v-m684-v259 medium
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link