Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply changes to dataclass docs from flytesnacks#1553 #5211

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Apr 10, 2024

Why are the changes needed?

The user guide docs have been moved to Flyte, so we need to re-apply changes from flyteorg/flytesnacks#1553.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytesnacks#1553

Docs link

TK

@neverett neverett self-assigned this Apr 10, 2024
@neverett neverett requested a review from ppiegaze as a code owner April 10, 2024 14:40
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 10, 2024
pingsutw
pingsutw previously approved these changes Apr 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to put the notes into the important section, not out of it.

image

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Apr 11, 2024
Signed-off-by: nikki everett <[email protected]>
@neverett
Copy link
Contributor Author

@Future-Outlier fixed!

Signed-off-by: nikki everett <[email protected]>
@neverett neverett enabled auto-merge (squash) April 11, 2024 19:45
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

image

@neverett neverett merged commit b36556e into master Apr 12, 2024
46 checks passed
@neverett neverett deleted the nikki/docs/port-dataclass-changes branch April 12, 2024 03:40
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants