Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Creating a Flyte project" with link to new Dockerfile project template #5215

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Apr 10, 2024

Changes in this PR

Updated "Creating a Flyte project" to reference the new flytekit Dockerfile template in "Creating a Flyte project" for users who need to use a Dockerfile instead of ImageSpec. Also fixes link to the basic ImageSpec template.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

TK

@neverett neverett self-assigned this Apr 10, 2024
@neverett neverett requested a review from ppiegaze as a code owner April 10, 2024 22:21
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 10, 2024
@neverett neverett requested a review from pingsutw April 10, 2024 22:22
pingsutw
pingsutw previously approved these changes Apr 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2024
Signed-off-by: nikki everett <[email protected]>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 11, 2024
@neverett neverett requested a review from pingsutw April 11, 2024 19:31
@neverett neverett enabled auto-merge (squash) April 11, 2024 19:44
@neverett neverett merged commit 734d6f3 into master Apr 11, 2024
46 checks passed
@neverett neverett deleted the nikki/docs/update-getting-started branch April 11, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants