[Feature] Refactor distributed job using common ReplicaSpec #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5355 +/- ##
==========================================
- Coverage 61.10% 61.09% -0.02%
==========================================
Files 793 793
Lines 51164 51182 +18
==========================================
+ Hits 31265 31270 +5
- Misses 17027 17040 +13
Partials 2872 2872
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
MortalHappiness
force-pushed
the
feature/#4408-refactor-replicaspec
branch
2 times, most recently
from
7051883 to
81bceca
Compare
MortalHappiness
force-pushed
the
feature/#4408-refactor-replicaspec
branch
from
81bceca to
946ca70
Compare
Resolves: flyteorg#4408 Signed-off-by: Chi-Sheng Liu <[email protected]>
Resolves: flyteorg#4408 Signed-off-by: Chi-Sheng Liu <[email protected]>
…uf changes Resolves: flyteorg#4408 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/#4408-refactor-replicaspec
branch
from
946ca70 to
b10a69e
Compare
eapolinario
approved these changes
Jun 12, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
…#5355) * feat(proto): Define CommonReplicaSpec in common.proto Resolves: flyteorg#4408 Signed-off-by: Chi-Sheng Liu <[email protected]> * chore(proto): Generate new clients corresponding to proto changes Resolves: flyteorg#4408 Signed-off-by: Chi-Sheng Liu <[email protected]> * feat(replica-spec): Update corresponding golang files based on protobuf changes Resolves: flyteorg#4408 Signed-off-by: Chi-Sheng Liu <[email protected]> --------- Signed-off-by: Chi-Sheng Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4408
Why are the changes needed?
See the description of the issue.
What changes were proposed in this pull request?
CommonReplicaSpecincommon.protoXXXReplicaSpec, embedCommonReplicaSpecand delete all the fields that are declared inCommonReplicaSpecHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytekit#2424
Docs link