Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some nits in workflow lifecycle docs. #5389

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

dansola
Copy link
Contributor

@dansola dansola commented May 17, 2024

Why are the changes needed?

Fixes some grammar, broken links and punctuation in the workflow lifecycle page.

What changes were proposed in this pull request?

Small nits

How was this patch tested?

N/A

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Page: https://docs.flyte.org/en/latest/concepts/workflow_lifecycle.html#understand-the-lifecycle-of-a-flyte-workflow

@dansola dansola requested review from neverett and ppiegaze as code owners May 17, 2024 23:22
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.99%. Comparing base (37fe0a3) to head (6777259).
Report is 119 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5389   +/-   ##
=======================================
  Coverage   60.99%   60.99%           
=======================================
  Files         794      794           
  Lines       51475    51475           
=======================================
  Hits        31398    31398           
  Misses      17185    17185           
  Partials     2892     2892           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.03% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.30% <ø> (ø)
unittests-flytestdlib 65.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dansola dansola enabled auto-merge (squash) May 24, 2024 13:51
@dansola dansola disabled auto-merge May 24, 2024 13:52
@dansola dansola enabled auto-merge (squash) May 24, 2024 16:51
@dansola dansola disabled auto-merge May 24, 2024 16:52
@dansola dansola enabled auto-merge (squash) May 24, 2024 17:15
@dansola dansola merged commit 12bd353 into master Jun 25, 2024
49 of 50 checks passed
@dansola dansola deleted the daniel-sola/DOC-388-lifecycle-nits branch June 25, 2024 21:56
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Daniel Sola <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants