Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlyterPropeller config to working config for flyte agent #5401

Closed

Conversation

Sovietaced
Copy link
Contributor

This pull request updates the flyte agent documentation to include working FlytePropeller configurations when running a custom agent/task. The previous configuration did not configure the agent service endpoint for propeller and attempts to run custom tasks would result in the following log messages. This also formats the YAML to 2 space indent.

❯ kubectl logs flytepropeller-5559db6f4d-bgpr7 -f | grep armada                                                                                                                                                            
{"json":{"exec_id":"f6bf36697f1a84994907","node":"examplesayhello","ns":"flytesnacks-development","res_ver":"32767965","routine":"worker-0","tasktype":"armada","wf":"flytesnacks:development:.flytegen.example.say_hello"},"level":"warning","msg":"No plugin found for Handler-type [armada], defaulting to [container]","ts":"2024-05-16T01:07:14Z"}
{"json":{"exec_id":"f6bf36697f1a84994907","node":"examplesayhello","ns":"flytesnacks-development","res_ver":"32767966","routine":"worker-0","tasktype":"armada","wf":"flytesnacks:development:.flytegen.example.say_hello"},"level":"warning","msg":"No plugin found for Handler-type [armada], defaulting to [container]","ts":"2024-05-16T01:07:14Z"}

@Sovietaced Sovietaced force-pushed the doc-flyte-propeller-config branch from 31696cf to d55eba5 Compare May 21, 2024 16:32
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.10%. Comparing base (458da5c) to head (6190d59).
Report is 164 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5401      +/-   ##
==========================================
+ Coverage   61.07%   61.10%   +0.02%     
==========================================
  Files         793      793              
  Lines       51210    51156      -54     
==========================================
- Hits        31275    31257      -18     
+ Misses      17059    17027      -32     
+ Partials     2876     2872       -4     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (+0.33%) ⬆️
unittests-flyteidl 79.30% <ø> (+0.25%) ⬆️
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sovietaced Sovietaced force-pushed the doc-flyte-propeller-config branch from df1f4ba to a39cfa0 Compare May 22, 2024 17:21
@Sovietaced Sovietaced force-pushed the doc-flyte-propeller-config branch from a39cfa0 to 6190d59 Compare May 22, 2024 17:24
@Sovietaced
Copy link
Contributor Author

#5460 should make this obsolete.

@Sovietaced Sovietaced closed this Jun 12, 2024
@Sovietaced Sovietaced deleted the doc-flyte-propeller-config branch June 12, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants