Inherit execution cluster label from source execution #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5431 +/- ##
=======================================
Coverage 61.07% 61.08%
=======================================
Files 793 793
Lines 51226 51229 +3
=======================================
+ Hits 31288 31291 +3
Misses 17062 17062
Partials 2876 2876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Vinayak Agarwal <[email protected]>
|
Congrats on merging your first pull request! 🎉 |
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Vinayak Agarwal <[email protected]>
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Vinayak Agarwal <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Today if a user creates an execution with the
execution-cluster-label, then the execution launches in the specified cluster. However, if the workflow has a reference workflow in the workflow, that reference workflow launches in the default cluster since this information isn't passed along. This change fixes that issue by inheriting the cluster label from the source.Why are the changes needed?
Without this change, part of the workflow will run in cluster 1 and part in cluster 2.
How was this patch tested?
In a local cluster, a workflow was launched with a reference workflow and the reference workflow launched in the correct cluster.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link