Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller] Watch agent metadata service dynamically #5460

Merged
merged 41 commits into from
Jun 28, 2024

Merge branch 'master' into watch-agent-dynamically

297d575
Select commit
Loading
Failed to load commit list.
Merged

[flytepropeller] Watch agent metadata service dynamically #5460

Merge branch 'master' into watch-agent-dynamically
297d575
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 26, 2024 in 0s

60.97% (-0.02%) compared to 5cc7f58

View this Pull Request on Codecov

60.97% (-0.02%) compared to 5cc7f58

Details

Codecov Report

Attention: Patch coverage is 56.89655% with 25 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (5cc7f58) to head (297d575).

Files Patch % Lines
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 46.66% 16 Missing ⚠️
...yteplugins/go/tasks/plugins/webapi/agent/client.go 64.28% 4 Missing and 1 partial ⚠️
...lytepropeller/pkg/controller/nodes/task/handler.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5460      +/-   ##
==========================================
- Coverage   60.99%   60.97%   -0.02%     
==========================================
  Files         794      794              
  Lines       51475    51488      +13     
==========================================
- Hits        31398    31397       -1     
- Misses      17185    17199      +14     
  Partials     2892     2892

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov