deep copying arraynode tasktemplate interface #5479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
ArrayNode strips the collection from the output type because it currently relies on registering a separate task with a wrapped collection to satisfy node output validators. The bug is that this stripped did no deep copy, so if multiple nodes stripped the outer collection, we would end up stripping mutliple layers if they existed.
What changes were proposed in this pull request?
In this PR we deep copy the interface of the TaskTemplate to ensure that multiple subNode executions do not strip mutliple
List
from the output variable type.How was this patch tested?
The following workflow is a minimal repro:
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA