Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doc building from flytectl #5494

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

N/A

Why are the changes needed?

flytectl documentation is built in the monorepo. These remaining files under the flytectl directory are no longer being used and are just sources of false positives in security scanning.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.00%. Comparing base (c10346d) to head (ce22670).
Report is 132 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5494      +/-   ##
==========================================
- Coverage   61.01%   61.00%   -0.01%     
==========================================
  Files         794      794              
  Lines       51441    51441              
==========================================
- Hits        31388    31384       -4     
- Misses      17161    17165       +4     
  Partials     2892     2892              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.03% <ø> (-0.06%) ⬇️
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.30% <ø> (ø)
unittests-flytestdlib 65.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit ed40a94 into master Jun 23, 2024
53 checks passed
@eapolinario eapolinario deleted the remove-doc-requirements-from-flytectl branch June 23, 2024 00:20
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants