Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] array node sub node control flow inheritance #5505

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Jun 24, 2024

Tracking issue

Why are the changes needed?

Array node increments workflow parallelism from the parent node. Right now, the same control flow that tracks parallelism for the workflow is passed down to subnodes allowing subnodes to bump the workflow parallelism which could lead to a double counting of nodes getting evaluated in a workflow.

If/when ArrayNode supports subworkflows or dynamics then we can pass back in the parent control flow.

What changes were proposed in this pull request?

Init a new control flow when creating the exec context for array node subnodes

How was this patch tested?

Ran a few workflows locally

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.01%. Comparing base (8805613) to head (a00afea).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5505      +/-   ##
==========================================
+ Coverage   60.15%   61.01%   +0.85%     
==========================================
  Files         646      794     +148     
  Lines       45883    51445    +5562     
==========================================
+ Hits        27603    31389    +3786     
- Misses      15672    17164    +1492     
- Partials     2608     2892     +284     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.03% <ø> (?)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.31% <100.00%> (+<0.01%) ⬆️
unittests-flytestdlib 65.82% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pvditt pvditt marked this pull request as ready for review June 24, 2024 17:27
@pvditt pvditt requested a review from hamersaw June 24, 2024 17:30
@pvditt pvditt marked this pull request as draft June 24, 2024 22:15
@pvditt
Copy link
Contributor Author

pvditt commented Jun 24, 2024

@hamersaw This would mess with the node + task count. I'll look back into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant