Helm chart updates related to Prometheus, Webhook HPA, and Flyteconsole probes #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Some flyte components were lacking metrics. clustersyncresources is especially necessary now that new projects are created frequently in serverless. But we should be monitoring all internal services to some extent. * Update clusterresourcesync to export metrics via httpendpoint * Update clusterresourcesync deployment with Prometheus scrape annotations, disabled by default * Update propeller deployment with Prometheus scrape annotations, disabled by default * Update webhook deployment with Prometheus scrape annotations, disabled by default * Create Webhook HPA, default disabled. Changes are intended to be forward-compatible, specifically with Prometheus Pod and ServiceMonitor. towards PE-912 towards PE-846 Signed-off-by: Mike Hotan <[email protected]>
* flyteconsole service monitor Signed-off-by: Mike Hotan <[email protected]>
Make flyteconsole readiness & liveness probe configurable Signed-off-by: Mike Hotan <[email protected]>
mhotan
force-pushed
the
mhotan/additional-prometheus-annotations
branch
from
713b7f5 to
e5d89bd
Compare
mhotan
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5508 +/- ##
==========================================
- Coverage 61.01% 61.01% -0.01%
==========================================
Files 794 794
Lines 51443 51445 +2
==========================================
- Hits 31390 31388 -2
- Misses 17161 17165 +4
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Congrats on merging your first pull request! 🎉 |
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
…le probes (flyteorg#5508) Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Various Helm chart updates deemed appropriate to upstream from Union internal usage.
How was this patch tested?
All three patches (commits) were tested individually within Union internal flyte deployment