add execution mode to ArrayNode proto #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <[email protected]>
pvditt
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5512 +/- ##
===========================================
- Coverage 60.98% 35.90% -25.09%
===========================================
Files 796 1301 +505
Lines 51676 109419 +57743
===========================================
+ Hits 31515 39287 +7772
- Misses 17261 66035 +48774
- Partials 2900 4097 +1197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Dittamo <[email protected]>
hamersaw
reviewed
Jun 26, 2024
This reverts commit f958241. Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
hamersaw
previously approved these changes
Jul 24, 2024
|
|
||
| // execution_version determines the execution path for ArrayNode. The default, 0, will | ||
| // utilize the minimized storage implementation. 1 will utilize full subNode status storage. | ||
| uint32 execution_version = 5; |
There was a problem hiding this comment.
Unsure if execution_mode sounds better? Then it should probably be an enum. Either way, whatever you decide is good.
3 tasks
pvditt
changed the title
Signed-off-by: Paul Dittamo <[email protected]>
hamersaw
approved these changes
Jul 26, 2024
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
* add execution_version to array node idl Signed-off-by: Paul Dittamo <[email protected]> * make execution_version for array node spec optional Signed-off-by: Paul Dittamo <[email protected]> * Revert "make execution_version for array node spec optional" This reverts commit f958241. Signed-off-by: Paul Dittamo <[email protected]> * update comment Signed-off-by: Paul Dittamo <[email protected]> * use enum instead of int for execution mode for array node Signed-off-by: Paul Dittamo <[email protected]> --------- Signed-off-by: Paul Dittamo <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Support selecting toggling ArrayNode execution/storage and retain backwards compatibility.
What changes were proposed in this pull request?
Add execution_version to ArrayNode proto
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link