Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix link to install scheduler plugins as gang scheduler for kubeflow plugins #5522

Closed
wants to merge 1 commit into from

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Jun 26, 2024

The current link gives 404.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@fg91 fg91 requested review from neverett and ppiegaze as code owners June 26, 2024 21:59
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (ce5eb03) to head (6617d16).
Report is 144 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5522      +/-   ##
==========================================
- Coverage   60.99%   60.98%   -0.01%     
==========================================
  Files         794      794              
  Lines       51475    51475              
==========================================
- Hits        31397    31392       -5     
- Misses      17186    17191       +5     
  Partials     2892     2892              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.69% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.03% <ø> (ø)
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.30% <ø> (ø)
unittests-flytestdlib 65.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett
Copy link
Contributor

Looks like this was fixed in #5524 -- sorry, I didn't see this earlier PR!

@fg91 fg91 closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants