Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dataclass Doc about dataclass_json import problem #5533

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Future-Outlier
Copy link
Member

It should be from dataclasses_json import dataclass_json.

Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier enabled auto-merge (squash) July 2, 2024 14:29
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (c512571) to head (dfb5c22).
Report is 114 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5533      +/-   ##
==========================================
+ Coverage   60.45%   60.94%   +0.48%     
==========================================
  Files         778      796      +18     
  Lines       50318    51640    +1322     
==========================================
+ Hits        30420    31471    +1051     
- Misses      17061    17264     +203     
- Partials     2837     2905      +68     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.41% <ø> (ø)
unittests-flyteidl 79.04% <ø> (?)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.29% <ø> (ø)
unittests-flytestdlib 65.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier merged commit 2407e90 into master Jul 2, 2024
49 of 50 checks passed
@Future-Outlier Future-Outlier deleted the fix-dataclass-doc-about-dataclasses-json branch July 2, 2024 14:49
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants