Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to release flytectl #5537

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

We moved flytectl to the monorepo but never documented how that affected the release process.

What changes were proposed in this pull request?

Document how to release flytectl from the monorepo.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario enabled auto-merge (squash) July 3, 2024 21:37
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (fc1c92c) to head (8cf0194).
Report is 112 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5537      +/-   ##
==========================================
+ Coverage   60.91%   60.93%   +0.01%     
==========================================
  Files         796      796              
  Lines       51689    51689              
==========================================
+ Hits        31488    31496       +8     
+ Misses      17294    17286       -8     
  Partials     2907     2907              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.47% <ø> (+0.05%) ⬆️
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.25% <ø> (ø)
unittests-flytestdlib 65.57% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 2b0e8ef into master Jul 3, 2024
53 checks passed
@eapolinario eapolinario deleted the document-how-to-release-flytectl branch July 3, 2024 21:57
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants