DOC-431 Document pyflyte option --overwrite-cache #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5567 +/- ##
===========================================
- Coverage 60.98% 35.90% -25.09%
===========================================
Files 796 1301 +505
Lines 51676 109401 +57725
===========================================
+ Hits 31515 39281 +7766
- Misses 17261 66023 +48762
- Partials 2900 4097 +1197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
neverett
previously approved these changes
Jul 23, 2024
neverett
changed the title
ppiegaze
force-pushed
the
peeter/doc-431-document-pyflyte-option-overwrite-cache
branch
from
927dc5c to
9358475
Compare
Signed-off-by: Peeter Piegaze <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
ppiegaze
force-pushed
the
peeter/doc-431-document-pyflyte-option-overwrite-cache
branch
from
4a31f17 to
edf31c8
Compare
Signed-off-by: Peeter Piegaze <[email protected]>
neverett
approved these changes
Jul 24, 2024
neverett
previously approved these changes
Jul 24, 2024
Signed-off-by: Peeter Piegaze <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
|
@neverett Please approve. Took some time to figure out why links of the form
to the |
neverett
approved these changes
Jul 26, 2024
ppiegaze
deleted the
peeter/doc-431-document-pyflyte-option-overwrite-cache
branch
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
* Document pyflyte option --overwrite-cache Signed-off-by: Peeter Piegaze <[email protected]> * Changes as per review Signed-off-by: Peeter Piegaze <[email protected]> * fix as per review Signed-off-by: Peeter Piegaze <[email protected]> * fix link Signed-off-by: Peeter Piegaze <[email protected]> * adjust wording Signed-off-by: Peeter Piegaze <[email protected]> * remove links to anchors, they don't work in Flyte dcos Signed-off-by: Peeter Piegaze <[email protected]> * try anchor links again Signed-off-by: Peeter Piegaze <[email protected]> * add back anchor links Signed-off-by: Peeter Piegaze <[email protected]> --------- Signed-off-by: Peeter Piegaze <[email protected]> Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://linear.app/unionai/issue/DOC-431/document-pyflyte-option-overwrite-cache
Why are the changes needed?
Info missing
What changes were proposed in this pull request?
Clarify caching parameters and add --overwrite-cache details