Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #5571

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix typos #5571

merged 3 commits into from
Jul 23, 2024

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Jul 20, 2024

Fix typos

omahs added 3 commits July 20, 2024 11:50
Signed-off-by: omahs <[email protected]>
Signed-off-by: omahs <[email protected]>
Signed-off-by: omahs <[email protected]>
@omahs omahs requested review from neverett and ppiegaze as code owners July 20, 2024 09:55
Copy link

welcome bot commented Jul 20, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.97%. Comparing base (fe879f2) to head (467dbd4).
Report is 121 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5571   +/-   ##
=======================================
  Coverage   60.96%   60.97%           
=======================================
  Files         796      796           
  Lines       51676    51676           
=======================================
+ Hits        31505    31508    +3     
+ Misses      17270    17268    -2     
+ Partials     2901     2900    -1     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.69% <ø> (+0.02%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.44% <ø> (ø)
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.76% <ø> (ø)
unittests-flytepropeller 57.48% <ø> (ø)
unittests-flytestdlib 65.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 71779b3 into flyteorg:master Jul 23, 2024
53 checks passed
Copy link

welcome bot commented Jul 23, 2024

Congrats on merging your first pull request! 🎉

vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: omahs <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants