Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacuse flyte-binary image has no version tag, it is replaced with fl… #5749

Closed
wants to merge 3 commits into from
Closed

beacuse flyte-binary image has no version tag, it is replaced with fl… #5749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9062434
beacuse flyte-binary image has no version tag, it is replaced with fl…
Sep 14, 2024
ff50e87
make helm to pass the test
sorushsaghari Sep 29, 2024
55a4db7
Merge branch 'master' into flyte-binary-default-image-fix
sorushsaghari Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/flyte-binary/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Chart for basic single Flyte executable deployment
| deployment.genAdminAuthSecret.args | list | `[]` | |
| deployment.genAdminAuthSecret.command | list | `[]` | |
| deployment.image.pullPolicy | string | `"IfNotPresent"` | |
| deployment.image.repository | string | `"cr.flyte.org/flyteorg/flyte-binary"` | |
| deployment.image.repository | string | `"cr.flyte.org/flyteorg/flyte-binary-release"` | |
| deployment.image.tag | string | `"latest"` | |
| deployment.initContainers | list | `[]` | |
| deployment.labels | object | `{}` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/flyte-binary/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ deployment:
# image Configure image to use for Flyte
image:
# repository Flyte image repository
repository: cr.flyte.org/flyteorg/flyte-binary # FLYTE_IMAGE
repository: cr.flyte.org/flyteorg/flyte-binary-release # FLYTE_IMAGE
# tag Flyte image tag
tag: latest # FLYTE_TAG
# pullPolicy Flyte image pull policy
Expand Down
2 changes: 1 addition & 1 deletion deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ spec:
done
containers:
- name: flyte
image: "cr.flyte.org/flyteorg/flyte-binary:latest"
image: "cr.flyte.org/flyteorg/flyte-binary-release:latest"
imagePullPolicy: "IfNotPresent"
args:
- start
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/complete-agent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: cmRzbzQ4N3RQaWhuMk00OA==
haSharedSecret: eTBtQjN1UGF6eml5Y2RDZg==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1413,7 +1413,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: 51528951e92c2bf712bbde990941593aae1fcf72144a1fe944c312ddad86e161
checksum/secret: c0554623a0c80277e5efb9480993a6ce7735b6af2a29ab94615116d491d39acb
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
4 changes: 2 additions & 2 deletions docker/sandbox-bundled/manifests/complete.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ type: Opaque
---
apiVersion: v1
data:
haSharedSecret: T1I2Q2tTcmREVG15MldGUQ==
haSharedSecret: UjJyWExzZzh5bUJUcGlpUA==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -1362,7 +1362,7 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: d723e395edc0fd2f221b9088efffe0d1f4dfabdef9892065fdabe12233362cf5
checksum/secret: 31592a6851bbd987aeedf3007a3cd3b35ce660610ab4319a6cef825102bb50e5
labels:
app: docker-registry
release: flyte-sandbox
Expand Down
5 changes: 3 additions & 2 deletions docker/sandbox-bundled/manifests/dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ metadata:
---
apiVersion: v1
data:
haSharedSecret: ZnltNHNiZ01NRFNkb1RlMA==
haSharedSecret: c2U1RWJGSDluQlhPNkRjQg==
proxyPassword: ""
proxyUsername: ""
kind: Secret
Expand Down Expand Up @@ -934,7 +934,8 @@ spec:
metadata:
annotations:
checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
checksum/secret: eeab364c20a0e8ad5a1526ccd7ddbd1d5a442087e7267c4d761279102b81be21
checksum/secret: 99c771b1bb9612755a73e5f0d2a96969471b3fe7de17439200dd8c2344f0a320

labels:
app: docker-registry
release: flyte-sandbox
Expand Down
Loading