Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename literal offloading flags and enable offloading in local config #5754

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

Linking to RFC: #5103

Why are the changes needed?

All the other flags use the format proposed in this PR.

What changes were proposed in this pull request?

Rename pflags for the new literal offloading feature. Also, enable it by default in the default dev config.

How was this patch tested?

A lot of local testing in combination with flyteorg/flytekit#2685.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@312910d). Learn more about missing BASE report.
Report is 159 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5754   +/-   ##
=========================================
  Coverage          ?   36.29%           
=========================================
  Files             ?     1305           
  Lines             ?   109991           
  Branches          ?        0           
=========================================
  Hits              ?    39923           
  Misses            ?    65913           
  Partials          ?     4155           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (?)
unittests-flyteadmin 55.62% <ø> (?)
unittests-flytecopilot 12.17% <ø> (?)
unittests-flytectl 62.21% <ø> (?)
unittests-flyteidl 7.12% <ø> (?)
unittests-flyteplugins 53.35% <ø> (?)
unittests-flytepropeller 41.87% <100.00%> (?)
unittests-flytestdlib 55.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
@eapolinario eapolinario enabled auto-merge (squash) September 18, 2024 14:55
@eapolinario eapolinario merged commit fd841ba into master Sep 18, 2024
50 checks passed
@eapolinario eapolinario deleted the rename-offloading-flags branch September 18, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants