Add semver check for dev and beta version #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
eapolinario
reviewed
Sep 18, 2024
Signed-off-by: pmahindrakar-oss <[email protected]>
eapolinario
approved these changes
Sep 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5757 +/- ##
=========================================
Coverage ? 36.29%
=========================================
Files ? 1305
Lines ? 109997
Branches ? 0
=========================================
Hits ? 39926
Misses ? 65915
Partials ? 4156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
katrogan
approved these changes
Sep 18, 2024
| @@ -133,6 +134,9 @@ var ( | |||
| MaxSizeInMBForOffloading: 1000, // 1 GB is the default size before failing fast. | |||
| }, | |||
| } | |||
|
|
|||
| // This regex is used to sanitize semver versions passed to IsSupportedSDK checks for literal offloading feature. | |||
There was a problem hiding this comment.
mind including an example of what this matches against with the dev sdk versions?
There was a problem hiding this comment.
Missed this. Will add in follow up PR.
There was a problem hiding this comment.
Added here #5758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Supporting dev and beta versions of the flytekit sdk during semver version checks for literal offloading feature.
Follow up to #5705
What changes were proposed in this pull request?
Do a regex match for the version string passed against a valid semver and use that for comparision with the supported one.
How was this patch tested?
Unit test added to test dev and beta versions
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link