Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propeller crash when inferring literal type for an offloaded literal #5771

Merged
merged 12 commits into from
Oct 2, 2024

review comments

9edd5f9
Select commit
Loading
Failed to load commit list.
Merged

Fix propeller crash when inferring literal type for an offloaded literal #5771

review comments
9edd5f9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 2, 2024 in 1s

43.90% of diff hit (target 36.31%)

View this Pull Request on Codecov

43.90% of diff hit (target 36.31%)

Annotations

Check warning on line 211 in flytepropeller/pkg/controller/nodes/array/handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/array/handler.go#L207-L211

Added lines #L207 - L211 were not covered by tests

Check warning on line 28 in flytepropeller/pkg/controller/nodes/attr_path_resolver.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/attr_path_resolver.go#L26-L28

Added lines #L26 - L28 were not covered by tests

Check warning on line 33 in flytepropeller/pkg/controller/nodes/attr_path_resolver.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/attr_path_resolver.go#L32-L33

Added lines #L32 - L33 were not covered by tests

Check warning on line 88 in flytepropeller/pkg/controller/nodes/common/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/common/utils.go#L88

Added line #L88 was not covered by tests

Check warning on line 92 in flytepropeller/pkg/controller/nodes/common/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/common/utils.go#L92

Added line #L92 was not covered by tests

Check warning on line 98 in flytepropeller/pkg/controller/nodes/common/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/common/utils.go#L97-L98

Added lines #L97 - L98 were not covered by tests

Check warning on line 139 in flytepropeller/pkg/controller/nodes/common/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/common/utils.go#L138-L139

Added lines #L138 - L139 were not covered by tests

Check warning on line 69 in flytepropeller/pkg/controller/nodes/output_resolver.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/output_resolver.go#L69

Added line #L69 was not covered by tests