Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write abort event for aborted k8s workflows #5785

Closed

lint

358151e
Select commit
Loading
Failed to load commit list.
Closed

Write abort event for aborted k8s workflows #5785

lint
358151e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2024 in 0s

36.32% (+0.00%) compared to 66ff152

View this Pull Request on Codecov

36.32% (+0.00%) compared to 66ff152

Details

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Project coverage is 36.32%. Comparing base (66ff152) to head (358151e).

Files with missing lines Patch % Lines
flyteadmin/pkg/workflowengine/impl/k8s_executor.go 76.92% 6 Missing ⚠️
flyteadmin/pkg/rpc/adminservice/base.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5785   +/-   ##
=======================================
  Coverage   36.31%   36.32%           
=======================================
  Files        1304     1304           
  Lines      110048   110067   +19     
=======================================
+ Hits        39964    39981   +17     
- Misses      65928    65930    +2     
  Partials     4156     4156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.