Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotations instead of delete CRDs when terminate execution #5789

Closed

Fix lint

a1083e6
Select commit
Loading
Failed to load commit list.
Closed

Use annotations instead of delete CRDs when terminate execution #5789

Fix lint
a1083e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 0s

36.31% (+0.00%) compared to 66ff152

View this Pull Request on Codecov

36.31% (+0.00%) compared to 66ff152

Details

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.31%. Comparing base (66ff152) to head (a1083e6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
flyteadmin/pkg/workflowengine/impl/k8s_executor.go 50.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5789   +/-   ##
=======================================
  Coverage   36.31%   36.31%           
=======================================
  Files        1304     1304           
  Lines      110048   110058   +10     
=======================================
+ Hits        39964    39972    +8     
+ Misses      65928    65927    -1     
- Partials     4156     4159    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.