-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new page under Data types and IO section for tensorflow_types in flyte documentation #5807
Added new page under Data types and IO section for tensorflow_types in flyte documentation #5807
Conversation
…ow types Signed-off-by: sumana sree <[email protected]>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5807 +/- ##
==========================================
- Coverage 36.84% 36.84% -0.01%
==========================================
Files 1309 1309
Lines 130994 130994
==========================================
- Hits 48271 48268 -3
- Misses 78533 78536 +3
Partials 4190 4190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@neverett do you think the failing test here has to do with content relocation? |
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: sumana sree <[email protected]>
@davidmirror-ops I don't think so, since the "Data types and I/O" section wasn't moved as part of the Flyte docs overhaul. It looks like the readthedocs test is passing and a bunch of other tests are pending -- can you point me to the test failure you're seeing? |
Signed-off-by: sumana sree <[email protected]>
Signed-off-by: Sumana Sree Angajala <[email protected]>
Signed-off-by: Sumana Sree Angajala <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: Sumana Sree Angajala <[email protected]>
@davidmirror-ops I'm so sorry, I have just tried to fix the errors in the tests. I don't know that it would cancel the approval. I'm unaware of that. Please don't mind my mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few suggestions, but otherwise this looks good to me. Feel free to request another review from me after you're done making changes!
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Sumana Sree Angajala <[email protected]>
@neverett I have included the changes can you please review it now. |
@davidmirror-ops, I have updated my forked repository to the latest commits; could you please proceed with merging this PR? |
Tracking issue
Closes #4065
Why are the changes needed?
What changes were proposed in this pull request?
This PR introduces a new page in the Data Types and IO section of the user guide, documenting all available TensorFlow types in Flyte. It includes detailed explanations of the
TensorFlowModel
,TFRecordFile
, andTFRecordsDirectory
, along with theTFRecordDatasetConfig
configuration class.Check all the applicable boxes
Docs link
Data Types and IO