Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic SASL and TLS support for Kafka cloud events #5814

Merged
merged 2 commits into from
Oct 31, 2024
+154 −18

Address comments

6d7a27f
Select commit
Loading
Failed to load commit list.
Merged

Add basic SASL and TLS support for Kafka cloud events #5814

Address comments
6d7a27f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 30, 2024 in 0s

11.11% of diff hit (target 36.84%)

View this Pull Request on Codecov

11.11% of diff hit (target 36.84%)

Annotations

Check warning on line 283 in flyteadmin/pkg/runtime/interfaces/application_configuration.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/runtime/interfaces/application_configuration.go#L283 

Added line #L283 was not covered by tests

Check warning on line 292 in flyteadmin/pkg/runtime/interfaces/application_configuration.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/runtime/interfaces/application_configuration.go#L287-L292 

Added lines #L287 - L292 were not covered by tests

Check warning on line 296 in flyteadmin/pkg/runtime/interfaces/application_configuration.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/runtime/interfaces/application_configuration.go#L294-L296 

Added lines #L294 - L296 were not covered by tests

Check warning on line 308 in flyteadmin/pkg/runtime/interfaces/application_configuration.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/runtime/interfaces/application_configuration.go#L299-L308 

Added lines #L299 - L308 were not covered by tests

Check warning on line 319 in flyteadmin/pkg/runtime/interfaces/application_configuration.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/runtime/interfaces/application_configuration.go#L312-L319 

Added lines #L312 - L319 were not covered by tests

Check warning on line 321 in flyteadmin/pkg/runtime/interfaces/application_configuration.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/runtime/interfaces/application_configuration.go#L321 

Added line #L321 was not covered by tests
View more details on Codecov