Add the ability of Flyteadmin to force terminate an execution #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Raposo <[email protected]>
RRap0so
force-pushed
the
rafaelraposo/force-abort-impl
branch
from
51a325a to
b8e7b27
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5817 +/- ##
==========================================
+ Coverage 34.48% 36.35% +1.86%
==========================================
Files 1138 1304 +166
Lines 102742 110165 +7423
==========================================
+ Hits 35434 40046 +4612
- Misses 63634 65950 +2316
- Partials 3674 4169 +495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RRap0so
force-pushed
the
rafaelraposo/force-abort-impl
branch
from
450c1cb to
3821a0c
Compare
Signed-off-by: Rafael Raposo <[email protected]>
RRap0so
force-pushed
the
rafaelraposo/force-abort-impl
branch
from
3821a0c to
2f0262d
Compare
2 tasks
RRap0so
changed the title
Signed-off-by: Rafael Raposo <[email protected]>
Signed-off-by: Rafael Raposo <[email protected]>
|
This was closed due to being unable to rebase and add signoffs. The replacement PR #5833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #5832
Why are the changes needed?
Add a force flag on the server side of Flyte to be able to terminate executions if FlytePropeller is not running in the kubernetes cluster.
What changes were proposed in this pull request?
This adds the force bool into
ExecutionTerminateRequest. This in turn will be passed to thek8s_executor. If it's a Forced termination, it will remove the finalizer from the execution CRD and delete.If it's not forced it keeps doing just a deletion (like it was before)
How was this patch tested?
Unit tested.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
TBD
Docs link
TBD