Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force flag when terminating execution #5836

Closed
wants to merge 1 commit into from

Conversation

RRap0so
Copy link
Contributor

@RRap0so RRap0so commented Oct 10, 2024

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@RRap0so RRap0so force-pushed the flytectl-force-flag branch from 584b9b8 to 491b504 Compare October 10, 2024 06:55
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.48%. Comparing base (197ae13) to head (491b504).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5836   +/-   ##
=======================================
  Coverage   34.48%   34.48%           
=======================================
  Files        1138     1138           
  Lines      102742   102742           
=======================================
+ Hits        35434    35435    +1     
+ Misses      63634    63633    -1     
  Partials     3674     3674           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RRap0so RRap0so closed this Oct 10, 2024
@RRap0so RRap0so deleted the flytectl-force-flag branch December 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant