Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #5839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

initial commit #5839

wants to merge 1 commit into from

Conversation

aazam-gh
Copy link

Tracking issue

Fixes #5738

Why are the changes needed?

In order to ensure that this example is reproducible.

What changes were proposed in this pull request?

Updating index.rst under docs/deployment/plugins

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Aazam Thakur <[email protected]>
Copy link

welcome bot commented Oct 10, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.34%. Comparing base (1942173) to head (a734312).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5839      +/-   ##
==========================================
+ Coverage   36.31%   36.34%   +0.02%     
==========================================
  Files        1304     1304              
  Lines      110048   110148     +100     
==========================================
+ Hits        39969    40032      +63     
- Misses      65923    65948      +25     
- Partials     4156     4168      +12     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.57% <ø> (-0.05%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.17% <ø> (+0.04%) ⬆️
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.00% <ø> (+0.07%) ⬆️
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor
Copy link
Contributor

@aazam-gh thanks for the pr. will let @davidmirror-ops comment on this when he's back next week, but this pr looks good. You tested the changes in demo cluster?

Also this pr doesn't close out the entire issue right? There's a couple other changes it needs?

@aazam-gh
Copy link
Author

Yes this pr does need to include more changes. I have not tested it yet, will do !

@neverett neverett requested review from davidmirror-ops and removed request for neverett and ppiegaze October 11, 2024 16:07
@eapolinario eapolinario requested a review from pingsutw December 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Cold PRs
Development

Successfully merging this pull request may close these issues.

[Docs] Ray plugin documentation missing details
2 participants