initial commit #5839

aazam-gh · 2024-10-10T10:58:08Z

Tracking issue

Fixes #5738

Why are the changes needed?

In order to ensure that this example is reproducible.

What changes were proposed in this pull request?

Updating index.rst under docs/deployment/plugins

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Aazam Thakur <[email protected]>

welcome · 2024-10-10T10:58:11Z

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
Sign off your commits (Reference: DCO Guide).

codecov · 2024-10-10T23:08:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.34%. Comparing base (1942173) to head (a734312).
Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5839      +/-   ##
==========================================
+ Coverage   36.31%   36.34%   +0.02%     
==========================================
  Files        1304     1304              
  Lines      110048   110148     +100     
==========================================
+ Hits        39969    40032      +63     
- Misses      65923    65948      +25     
- Partials     4156     4168      +12

Flag	Coverage Δ
unittests-datacatalog	`51.37% <ø> (ø)`
unittests-flyteadmin	`55.57% <ø> (-0.05%)`	⬇️
unittests-flytecopilot	`12.17% <ø> (ø)`
unittests-flytectl	`62.21% <ø> (ø)`
unittests-flyteidl	`7.17% <ø> (+0.04%)`	⬆️
unittests-flyteplugins	`53.35% <ø> (ø)`
unittests-flytepropeller	`42.00% <ø> (+0.07%)`	⬆️
unittests-flytestdlib	`55.35% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wild-endeavor · 2024-10-10T23:08:25Z

@aazam-gh thanks for the pr. will let @davidmirror-ops comment on this when he's back next week, but this pr looks good. You tested the changes in demo cluster?

Also this pr doesn't close out the entire issue right? There's a couple other changes it needs?

aazam-gh · 2024-10-11T15:12:45Z

Yes this pr does need to include more changes. I have not tested it yet, will do !

davidmirror-ops · 2025-01-07T19:23:23Z

docs/deployment/plugins/k8s/index.rst

@@ -431,7 +431,20 @@ Specify plugin configuration
                            - kind: ServiceAccount
                              name: spark
                              namespace: "{{ namespace }}"
-
+                  rbac:


Suggested change

rbac:

@aazam-gh Please remove this whole section as it belongs to Spark config, which is not the focus of the issue

davidmirror-ops

@aazam-gh thanks for contributing and really sorry about the delays.

This is the relevant section that has to be updated:

flyte/docs/deployment/plugins/k8s/index.rst

Lines 252 to 304 in 27c9edd

    
             .. group-tab:: Ray 
        
               .. tabs:: 
        
                 .. group-tab:: Flyte binary 
        
                   Create a file named ``values-override.yaml`` and add the following config to it: 
        
                   .. code-block:: yaml 
        
                      configuration: 
        
                        inline: 
        
                          tasks: 
        
                            task-plugins: 
        
                              enabled-plugins: 
        
                                - container 
        
                                - sidecar 
        
                                - k8s-array 
        
                                - ray 
        
                              default-for-task-types: 
        
                                - container: container 
        
                                - container_array: k8s-array 
        
                                - ray: ray 
        
                          plugins: 
        
                           ray: 
        
                             // Shutdown Ray cluster after 1 hour of inactivity 
        
                             ttlSecondsAfterFinished: 3600 
        
                 .. group-tab:: Flyte core 
        
                   Create a file named ``values-override.yaml`` and add the following config to it: 
        
                   .. code-block:: yaml 
        
                     :emphasize-lines: 9,14 
        
                     configmap: 
        
                       enabled_plugins: 
        
                         tasks: 
        
                           task-plugins: 
        
                             enabled-plugins: 
        
                               - container 
        
                               - sidecar 
        
                               - k8s-array 
        
                               - ray 
        
                             default-for-task-types: 
        
                               container: container 
        
                               sidecar: sidecar 
        
                               container_array: k8s-array 
        
                               ray: ray 
        
                         plugins: 
        
                           ray: 
        
                             // Shutdown Ray cluster after 1 hour of inactivity 
        
                             ttlSecondsAfterFinished: 3600

Let me know if you need help

Thanks

davidmirror-ops · 2025-01-07T19:23:55Z

docs/deployment/plugins/k8s/index.rst

@@ -431,7 +431,20 @@ Specify plugin configuration
                            - kind: ServiceAccount
                              name: spark
                              namespace: "{{ namespace }}"
-
+                  rbac:


@aazam-gh Please remove this whole section as it belongs to Spark config, which is not the focus of the issue

davidmirror-ops · 2025-01-07T19:24:23Z

docs/deployment/plugins/k8s/index.rst

@@ -595,7 +608,20 @@ Specify plugin configuration
                            - kind: ServiceAccount
                              name: spark
                              namespace: "{{ namespace }}"
-
+                  rbac:


Suggested change

rbac:

Same here, this section is not Ray but Spark. Please remove

davidmirror-ops · 2025-01-07T19:24:36Z

docs/deployment/plugins/k8s/index.rst

@@ -687,7 +713,20 @@ Specify plugin configuration
                        - kind: ServiceAccount
                          name: spark
                          namespace: {{ namespace }}
-
+                  rbac:


Suggested change

rbac:

davidmirror-ops · 2025-01-07T19:24:55Z

docs/deployment/plugins/k8s/index.rst

@@ -748,6 +787,20 @@ Specify plugin configuration
                          - development:
                              - gsa:
                                  value: "<GoogleServiceAccount-email>"
+                  rbac:


Suggested change

rbac:

initial commit

a734312

Signed-off-by: Aazam Thakur <[email protected]>

aazam-gh requested review from neverett and ppiegaze as code owners October 10, 2024 10:58

neverett requested review from davidmirror-ops and removed request for neverett and ppiegaze October 11, 2024 16:07

eapolinario requested a review from pingsutw December 19, 2024 18:52

davidmirror-ops reviewed Jan 7, 2025

View reviewed changes

davidmirror-ops requested changes Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial commit #5839

initial commit #5839

aazam-gh commented Oct 10, 2024

welcome bot commented Oct 10, 2024

codecov bot commented Oct 10, 2024 •

edited

Loading

wild-endeavor commented Oct 10, 2024

aazam-gh commented Oct 11, 2024

davidmirror-ops Jan 7, 2025

davidmirror-ops Jan 7, 2025

davidmirror-ops left a comment

davidmirror-ops Jan 7, 2025

davidmirror-ops Jan 7, 2025

davidmirror-ops Jan 7, 2025

davidmirror-ops Jan 7, 2025

	.. group-tab:: Ray

	.. tabs::

	.. group-tab:: Flyte binary

	Create a file named ``values-override.yaml`` and add the following config to it:

	.. code-block:: yaml

	configuration:
	inline:
	tasks:
	task-plugins:
	enabled-plugins:
	- container
	- sidecar
	- k8s-array
	- ray
	default-for-task-types:
	- container: container
	- container_array: k8s-array
	- ray: ray
	plugins:
	ray:
	// Shutdown Ray cluster after 1 hour of inactivity
	ttlSecondsAfterFinished: 3600

	.. group-tab:: Flyte core

	Create a file named ``values-override.yaml`` and add the following config to it:

	.. code-block:: yaml
	:emphasize-lines: 9,14

	configmap:
	enabled_plugins:
	tasks:
	task-plugins:
	enabled-plugins:
	- container
	- sidecar
	- k8s-array
	- ray
	default-for-task-types:
	container: container
	sidecar: sidecar
	container_array: k8s-array
	ray: ray
	plugins:
	ray:
	// Shutdown Ray cluster after 1 hour of inactivity
	ttlSecondsAfterFinished: 3600

initial commit #5839

Are you sure you want to change the base?

initial commit #5839

Conversation

aazam-gh commented Oct 10, 2024

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

welcome bot commented Oct 10, 2024

codecov bot commented Oct 10, 2024 • edited Loading

Codecov Report

wild-endeavor commented Oct 10, 2024

aazam-gh commented Oct 11, 2024

davidmirror-ops Jan 7, 2025

Choose a reason for hiding this comment

davidmirror-ops Jan 7, 2025

Choose a reason for hiding this comment

davidmirror-ops left a comment

Choose a reason for hiding this comment

davidmirror-ops Jan 7, 2025

Choose a reason for hiding this comment

davidmirror-ops Jan 7, 2025

Choose a reason for hiding this comment

davidmirror-ops Jan 7, 2025

Choose a reason for hiding this comment

davidmirror-ops Jan 7, 2025

Choose a reason for hiding this comment

codecov bot commented Oct 10, 2024 •

edited

Loading