Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add David as codeowner of deployment docs #5841

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Oct 11, 2024

What changes were proposed in this pull request?

Adds @davidmirror-ops as codeowner of deployment guide docs so he is added as a reviewer on PRs for them.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@neverett neverett self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.35%. Comparing base (197ae13) to head (8165b4d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5841      +/-   ##
==========================================
+ Coverage   34.48%   36.35%   +1.86%     
==========================================
  Files        1138     1304     +166     
  Lines      102742   110148    +7406     
==========================================
+ Hits        35434    40043    +4609     
- Misses      63634    65938    +2304     
- Partials     3674     4167     +493     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (?)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidmirror-ops davidmirror-ops merged commit f2a0619 into master Oct 15, 2024
50 checks passed
@davidmirror-ops davidmirror-ops deleted the nikki/docs/update-codeowners branch October 15, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants