[Docs] add practical example to improve data management doc #5844
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
|
|
||
| .. code-block:: python | ||
| @task() | ||
| def task_remove_column(input_file: FlyteFile, column_name: str) -> FlyteFile: | ||
| """ |
There was a problem hiding this comment.
Not sure is this the right way or should we move to flytesnacks
Good idea! fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5844 +/- ##
==========================================
+ Coverage 34.48% 36.72% +2.23%
==========================================
Files 1138 1304 +166
Lines 102742 130072 +27330
==========================================
+ Hits 35434 47764 +12330
- Misses 63634 78138 +14504
- Partials 3674 4170 +496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DenChenn
force-pushed
the
docs/improve-data-management
branch
from
f0f0d69 to
10c34dc
Compare
DenChenn
force-pushed
the
docs/improve-data-management
branch
2 times, most recently
from
cf42ec7 to
9d96f59
Compare
DenChenn
force-pushed
the
docs/improve-data-management
branch
3 times, most recently
from
30245c1 to
c81b534
Compare
DenChenn
force-pushed
the
docs/improve-data-management
branch
from
c81b534 to
fea2977
Compare
|
@neverett Thanks for reviewing! done. |
Signed-off-by: DenChenn <[email protected]>
DenChenn
force-pushed
the
docs/improve-data-management
branch
from
fea2977 to
489051f
Compare
|
@DenChenn can you check the failing docs build test? |
|
Looks like a connection error -- I can rerun the test. |
|
@neverett Thanks! |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: DenChenn <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: DenChenn <[email protected]>
|
|
||
| .. note: | ||
| Metadata and raw data can be present in entirely separate buckets. | ||
| <a href="https://github.com/flyteorg/flyte/blob/6c4f8dbfc6d23a0cd7bf81480856e9ae1dfa1b27/flytepropeller/pkg/controller/config/config.go#L184-L192">View source code on GitHub</a> |
There was a problem hiding this comment.
@Future-Outlier Since .rst doesn't support remote links, I'm using HTML to reference the gitsha link.
|
Congrats on merging your first pull request! 🎉 |
Tracking issue
Related to #4456
Why are the changes needed?
Based on user feedback, some users understand the basics of data management in Flyte but are unsure how to implement it, so I’ve added examples to help them follow along more easily.
Docs link
https://flyte--5844.org.readthedocs.build/en/5844/user_guide/concepts/main_concepts/data_management.html