Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add streaming support example for file and directory #5879

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

DenChenn
Copy link
Member

@DenChenn DenChenn commented Oct 21, 2024

Tracking issue

Related to #4460
Example PR: flyteorg/flytesnacks#1759

Why are the changes needed?

This PR introduces file streaming support for both FlyteFile and FlyteDirectory in our document.

Related PRs

flyteorg/flytekit#1512

Docs link

https://flyte--5879.org.readthedocs.build/en/5879/user_guide/data_types_and_io/flytefile.html
https://flyte--5879.org.readthedocs.build/en/5879/user_guide/data_types_and_io/flytedirectory.html

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.71%. Comparing base (38af4ec) to head (e35f695).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5879      +/-   ##
==========================================
- Coverage   36.72%   36.71%   -0.01%     
==========================================
  Files        1304     1304              
  Lines      130072   130081       +9     
==========================================
- Hits        47764    47757       -7     
- Misses      78138    78154      +16     
  Partials     4170     4170              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.39% <ø> (-0.05%) ⬇️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.89% <ø> (ø)
unittests-flyteplugins 53.62% <ø> (ø)
unittests-flytepropeller 42.84% <ø> (ø)
unittests-flytestdlib 54.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DenChenn DenChenn force-pushed the docs/add-file-streaming-support branch from 6ae999d to 4ba7fdc Compare October 21, 2024 15:21
@DenChenn DenChenn force-pushed the docs/add-file-streaming-support branch from a116eb0 to e35f695 Compare October 21, 2024 15:37
@DenChenn DenChenn marked this pull request as ready for review October 21, 2024 15:58
@pingsutw pingsutw merged commit 653b926 into flyteorg:master Oct 21, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants