Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Recover the expected behaviors of example workflows #5880

Conversation

JiangJiaWei1103
Copy link
Contributor

@JiangJiaWei1103 JiangJiaWei1103 commented Oct 21, 2024

Why are the changes needed?

  1. The import statement of Echo is missing.
  2. The demonstration of the workflow shape_properties_accept_conditional_output is ignored in the main function right below it.
  3. The descriptions of expected outputs of the workflow consume_task_output are inverted.

What changes were proposed in this pull request?

Reassign the example code url with the new gitsha and align code lines.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All commits are signed-off.

Related PRs

The modified version of the example code in Flytesnacks can be found in this PR

Docs link

https://flyte--5880.org.readthedocs.build/en/5880/user_guide/advanced_composition/conditionals.html

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.71%. Comparing base (bdaf79f) to head (47bf054).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5880   +/-   ##
=======================================
  Coverage   36.71%   36.71%           
=======================================
  Files        1304     1304           
  Lines      130081   130081           
=======================================
  Hits        47764    47764           
  Misses      78147    78147           
  Partials     4170     4170           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.41% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.89% <ø> (ø)
unittests-flyteplugins 53.62% <ø> (ø)
unittests-flytepropeller 42.84% <ø> (ø)
unittests-flytestdlib 54.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier merged commit 9d63d0a into flyteorg:master Oct 23, 2024
50 checks passed
@JiangJiaWei1103 JiangJiaWei1103 deleted the recover-expected-behaviors-of-workflows branch October 26, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants