Added documentation about Fixed and unique domains #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AYUSH SAHU <[email protected]>
|
@neverett @davidmirror-ops Please have a look at this Pull Request. I included the info about uniqueness of Domains 🙌 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5923 +/- ##
=======================================
Coverage 36.84% 36.84%
=======================================
Files 1309 1309
Lines 130967 130967
=======================================
+ Hits 48252 48258 +6
+ Misses 78531 78525 -6
Partials 4184 4184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: AYUSH SAHU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4392
Why are the changes needed?
The information is needed so that new users do not get confused as why they are not able to create domains. As the domains are fixed.
What changes were proposed in this pull request?
It was a simple documentation change.
Check all the applicable boxes
Docs link
Page where the changes should be visible once the PR is merged : link