Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to verify that the grpc service of flyteadmin works as expected #5958

Conversation

popojk
Copy link
Contributor

@popojk popojk commented Nov 5, 2024

Tracking issue

Closes #3163

Why are the changes needed?

In this discussion, a user encountered a TLS certificate issue while registering a workflow to the Flyte-core k8s cluster. The root cause was TLS not being enabled in the Kubernetes cluster’s Ingress controller. It is recommended to add this debug information to the troubleshooting guide documentation.

What changes were proposed in this pull request?

Add information about flyte-core k8s ingress TLS config in the trouble shooting DOC.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All commits are signed-off.

Docs link

https://flyte--5958.org.readthedocs.build/en/5958/community/troubleshoot.html

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.81%. Comparing base (f745030) to head (ee4363a).
Report is 44 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5958   +/-   ##
=======================================
  Coverage   36.81%   36.81%           
=======================================
  Files        1310     1310           
  Lines      131032   131034    +2     
=======================================
+ Hits        48234    48237    +3     
+ Misses      78612    78611    -1     
  Partials     4186     4186           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.04% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.39% <ø> (+<0.01%) ⬆️
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 42.90% <ø> (ø)
unittests-flytestdlib 55.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Future-Outlier Future-Outlier merged commit ff31a5b into flyteorg:master Nov 20, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Docs] How to verify that the GRPC service of flyteadmin works as expected
3 participants