Allow flytepropeller manager to have different resource request from flyte propeller #5974
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flyte propeller This can be good since the flytepropeller-manager pod does no work and needs next to no resources Signed-off-by: Christoph Paulik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5974 +/- ##
==========================================
+ Coverage 33.35% 37.09% +3.74%
==========================================
Files 1021 1318 +297
Lines 108502 132399 +23897
==========================================
+ Hits 36193 49118 +12925
- Misses 69098 79009 +9911
- Partials 3211 4272 +1061
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
previously approved these changes
Dec 5, 2024
…sources Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight resource optimization since the flytepropeller-manager pod does no work and needs next to no resources. But in the default configuration it has the same size as each sharded flyte propeller deployment.
Why are the changes needed?
To not waste CPU / Mem on flytepropeller manager which does very little work
What changes were proposed in this pull request?
Allow usage of
flytepropeller.manager_resourcesto specify resource requests forflytepropeller-managerseparately from the shareded flyte propeller deployments.How was this patch tested?
I ran built the helm chart with this setting and the resulting
ymlfiles looked ok.Check all the applicable boxes
make helm