[flytectl][MSGPACK IDL] Gate feature by setting ENV #5976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#5318
Why are the changes needed?
We want to ease the pain of generic IDL -> msgpack IDL when the user upgrades to flyte 1.14.
What changes were proposed in this pull request?
os.environ["FLYTE_USE_OLD_DC_FORMAT"] = "true"
, then use old behavior to generate protobuf struct in the generic IDL.else generate msgpack IDL.
[flytectl] Use Protobuf Struct as dataclass Input for backward compatibility #5840
note: use
envs
is passed to flyteadmin to inform that the first task pod need to injectenvs
in this file, but not be used to command line createprotobuf struct
.How was this patch tested?
use
flytectl create execution
and unit test.Setup process
pyflyte run --remote a worfklow
(msgpack idl) use flytectl to create an execution
(protobuf struct) use flytectl to create an execution
Screenshots
msgpack idl
protobuf struct
Check all the applicable boxes