Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt protogetter #5981

Merged
merged 16 commits into from
Nov 14, 2024

Fix lint warnings in literals_test.go

87eea97
Select commit
Loading
Failed to load commit list.
Merged

Adopt protogetter #5981

Fix lint warnings in literals_test.go
87eea97
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 14, 2024 in 1s

77.75% of diff hit (target 36.97%)

View this Pull Request on Codecov

77.75% of diff hit (target 36.97%)

Annotations

Check warning on line 117 in datacatalog/pkg/manager/impl/artifact_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/artifact_manager.go#L117 

Added line #L117 was not covered by tests

Check warning on line 338 in datacatalog/pkg/manager/impl/artifact_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/artifact_manager.go#L338 

Added line #L338 was not covered by tests

Check warning on line 387 in datacatalog/pkg/manager/impl/artifact_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/artifact_manager.go#L387 

Added line #L387 was not covered by tests

Check warning on line 84 in datacatalog/pkg/manager/impl/dataset_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/dataset_manager.go#L84 

Added line #L84 was not covered by tests

Check warning on line 174 in datacatalog/pkg/manager/impl/dataset_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/dataset_manager.go#L174 

Added line #L174 was not covered by tests

Check warning on line 87 in datacatalog/pkg/manager/impl/validators/artifact_validator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/validators/artifact_validator.go#L87 

Added line #L87 was not covered by tests

Check warning on line 39 in datacatalog/pkg/manager/impl/validators/dataset_validator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/validators/dataset_validator.go#L39 

Added line #L39 was not covered by tests

Check warning on line 30 in datacatalog/pkg/manager/impl/validators/pagination_validator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/validators/pagination_validator.go#L30 

Added line #L30 was not covered by tests

Check warning on line 36 in datacatalog/pkg/manager/impl/validators/pagination_validator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/validators/pagination_validator.go#L35-L36 

Added lines #L35 - L36 were not covered by tests

Check warning on line 41 in datacatalog/pkg/manager/impl/validators/pagination_validator.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/manager/impl/validators/pagination_validator.go#L39-L41 

Added lines #L39 - L41 were not covered by tests

Check warning on line 65 in datacatalog/pkg/repositories/errors/postgres.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

datacatalog/pkg/repositories/errors/postgres.go#L65 

Added line #L65 was not covered by tests

Check warning on line 80 in flyteadmin/auth/init_secrets.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/auth/init_secrets.go#L80 

Added line #L80 was not covered by tests

Check warning on line 87 in flyteadmin/auth/init_secrets.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/auth/init_secrets.go#L87 

Added line #L87 was not covered by tests

Check warning on line 94 in flyteadmin/auth/init_secrets.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/auth/init_secrets.go#L94 

Added line #L94 was not covered by tests

Check warning on line 126 in flyteadmin/dataproxy/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/dataproxy/service.go#L126 

Added line #L126 was not covered by tests

Check warning on line 251 in flyteadmin/dataproxy/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/dataproxy/service.go#L251 

Added line #L251 was not covered by tests

Check warning on line 356 in flyteadmin/dataproxy/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/dataproxy/service.go#L355-L356 

Added lines #L355 - L356 were not covered by tests

Check warning on line 373 in flyteadmin/dataproxy/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/dataproxy/service.go#L373 

Added line #L373 was not covered by tests

Check warning on line 386 in flyteadmin/dataproxy/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/dataproxy/service.go#L386 

Added line #L386 was not covered by tests

Check warning on line 421 in flyteadmin/dataproxy/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/dataproxy/service.go#L421 

Added line #L421 was not covered by tests

Check warning on line 131 in flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go#L131 

Added line #L131 was not covered by tests

Check warning on line 137 in flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go#L137 

Added line #L137 was not covered by tests

Check warning on line 147 in flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go#L145-L147 

Added lines #L145 - L147 were not covered by tests

Check warning on line 150 in flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go#L150 

Added line #L150 was not covered by tests

Check warning on line 155 in flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/cloudevent/implementations/cloudevent_publisher.go#L155 

Added line #L155 was not covered by tests
View more details on Codecov