Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #5933 to release-v.13 #5999

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Sovietaced
Copy link
Contributor

Cherry picks #5933 onto the 1.13 release branch

@Sovietaced Sovietaced marked this pull request as ready for review November 12, 2024 21:50
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 6.91%. Comparing base (b5de6c1) to head (a03f19a).
Report is 1 commits behind head on release-v1.13.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/plugins/ray.pb.go 0.00% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b5de6c1) and HEAD (a03f19a). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (b5de6c1) HEAD (a03f19a)
unittests-datacatalog 1 0
unittests-flytecopilot 1 0
unittests-flytectl 1 0
unittests-flyteadmin 1 0
unittests-flytepropeller 1 0
unittests-flyteplugins 1 0
unittests-flytestdlib 1 0
Additional details and impacted files
@@                Coverage Diff                @@
##           release-v1.13   #5999       +/-   ##
=================================================
- Coverage          36.76%   6.91%   -29.85%     
=================================================
  Files               1309     146     -1163     
  Lines             130801   41739    -89062     
=================================================
- Hits               48083    2886    -45197     
+ Misses             78544   38669    -39875     
+ Partials            4174     184     -3990     
Flag Coverage Δ
unittests-datacatalog ?
unittests-flyteadmin ?
unittests-flytecopilot ?
unittests-flytectl ?
unittests-flyteidl 6.91% <0.00%> (-0.01%) ⬇️
unittests-flyteplugins ?
unittests-flytepropeller ?
unittests-flytestdlib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sovietaced Sovietaced changed the title Decouple ray submitter, worker, and head resources Backport #5933 to release-v.13 Nov 12, 2024
@Sovietaced Sovietaced merged commit f04d0a7 into flyteorg:release-v1.13 Nov 12, 2024
45 of 49 checks passed
@Sovietaced Sovietaced deleted the release-v1.13 branch November 12, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant