Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribute_code.rst #6009

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

davidlin20dev
Copy link
Contributor

Fix typos:
Corrected 'officail' to 'official' and 'flitekit' to 'flytekit'

Tracking issue

N/A

Why are the changes needed?

These typos in the documentation could confuse new users trying to set up their development environment. Clear and accurate documentation is essential for a good developer experience.

What changes were proposed in this pull request?

Fixed two typos in contribute_code.rst:

  1. Changed 'officail' to 'official'
  2. Changed 'flitekit' to 'flytekit'

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

https://docs.flyte.org/en/latest/community/contribute/contribute_code.html#flytekit

Fix typos:
Corrected 'officail' to 'official' and 'flitekit' to 'flytekit'


Signed-off-by: davidlin20dev <[email protected]>
Copy link

welcome bot commented Nov 14, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@wild-endeavor wild-endeavor enabled auto-merge (squash) November 15, 2024 01:08
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.97%. Comparing base (da220be) to head (c896c4e).
Report is 28 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6009   +/-   ##
=======================================
  Coverage   36.97%   36.97%           
=======================================
  Files        1312     1312           
  Lines      131525   131525           
=======================================
  Hits        48632    48632           
  Misses      78666    78666           
  Partials     4227     4227           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.39% <ø> (ø)
unittests-flyteidl 7.05% <ø> (ø)
unittests-flyteplugins 53.83% <ø> (ø)
unittests-flytepropeller 43.10% <ø> (ø)
unittests-flytestdlib 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@wild-endeavor wild-endeavor merged commit 6f187ae into flyteorg:master Nov 22, 2024
51 checks passed
Copy link

welcome bot commented Nov 22, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants