Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ArrayNode subNode timeouts #6054

Merged
merged 11 commits into from
Dec 5, 2024
+208 −35

removed tmp ArrayNode NodeSpec field overrides

36601df
Select commit
Loading
Failed to load commit list.
Merged

Support ArrayNode subNode timeouts #6054

removed tmp ArrayNode NodeSpec field overrides
36601df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

37.09% (+0.00%) compared to ab04192

View this Pull Request on Codecov

37.09% (+0.00%) compared to ab04192

Details

Codecov Report

Attention: Patch coverage is 27.53623% with 50 lines in your changes missing coverage. Please review.

Project coverage is 37.09%. Comparing base (ab04192) to head (36601df).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...eworkflow/v1alpha1/mocks/MutableArrayNodeStatus.go 0.00% 20 Missing ⚠️
...rkflow/v1alpha1/mocks/ExecutableArrayNodeStatus.go 0.00% 18 Missing ⚠️
...ler/pkg/apis/flyteworkflow/v1alpha1/node_status.go 0.00% 7 Missing ⚠️
...opeller/pkg/controller/nodes/node_state_manager.go 0.00% 4 Missing ⚠️
...lytepropeller/pkg/controller/nodes/transformers.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #6054    +/-   ##
========================================
  Coverage   37.08%   37.09%            
========================================
  Files        1318     1318            
  Lines      132284   132399   +115     
========================================
+ Hits        49062    49117    +55     
- Misses      78950    79010    +60     
  Partials     4272     4272

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov