Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable literal offloading in flyte-binary and flyte-core #6087

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Dec 5, 2024

Tracking issue

NA

Why are the changes needed?

Literal offloading should be enabled by default in Flyte 1.14.0.

What changes were proposed in this pull request?

Enable literal offloading in flyte-core and flyte-binary helm charts and also bump the minimal supported version of flytekit to 1.13.14.

How was this patch tested?

Tested on a locally built flyte-sandbox image.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.09%. Comparing base (de12c82) to head (8b888dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6087      +/-   ##
==========================================
+ Coverage   33.35%   37.09%   +3.74%     
==========================================
  Files        1021     1318     +297     
  Lines      108502   132399   +23897     
==========================================
+ Hits        36193    49118   +12925     
- Misses      69098    79009    +9911     
- Partials     3211     4272    +1061     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (?)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.82% <ø> (ø)
unittests-flytepropeller 42.59% <ø> (ø)
unittests-flytestdlib 57.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit 7fcbdf9 into master Dec 5, 2024
57 checks passed
@davidmirror-ops davidmirror-ops deleted the enable-offloading-in-sandbox branch December 5, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants