Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove the default search dialog if it exists (on CMD + K) #6106

Merged

Conversation

chmod77
Copy link
Contributor

@chmod77 chmod77 commented Dec 13, 2024

Why are the changes needed?

  • Hitting CMD + K pops up two search dialogs (the docsearch and the default one)

What changes were proposed in this pull request?

This PR adds a script block that gracefully removes the default search dialog from the tree.

How was this patch tested?

  1. Build
  2. Serve
  3. Hit CMD + K

Screenshots

Screenshot 2024-12-13 at 09 49 49

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@chmod77 chmod77 requested a review from ppiegaze as a code owner December 13, 2024 06:51
@chmod77 chmod77 force-pushed the shalom/fix-cmd-k-double-search-inputs branch from cf64fbf to 152e332 Compare December 13, 2024 06:54
@ppiegaze ppiegaze requested a review from cosmicBboy December 13, 2024 08:41
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.98%. Comparing base (d770918) to head (152e332).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6106      +/-   ##
==========================================
- Coverage   36.99%   36.98%   -0.01%     
==========================================
  Files        1318     1318              
  Lines      132406   132439      +33     
==========================================
+ Hits        48979    48980       +1     
- Misses      79174    79206      +32     
  Partials     4253     4253              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.06% <ø> (-0.05%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (-0.01%) ⬇️
unittests-flyteplugins 53.82% <ø> (ø)
unittests-flytepropeller 42.60% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppiegaze ppiegaze merged commit e21a6ad into flyteorg:master Dec 16, 2024
51 of 52 checks passed
Copy link

welcome bot commented Dec 16, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants