Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sandbox-bundled-offloaded-functional-tests for offloading literals unit test #6111

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Mecoli1219
Copy link

@Mecoli1219 Mecoli1219 commented Dec 17, 2024

Why are the changes needed?

Currently, there seems to be no CI test covering the end-to-end offloaded test at the flyte repo. This PR create one.

What changes were proposed in this pull request?

Copy the sandbox-bundled-functional-test, and add new propeller parameters in the flyte config.yaml file. By setting the min-size-in-mb-for-offloading to be 0.000001 (aka. 1e-6MB = 1B), almost all the output of the task should be offloaded.

How was this patch tested?

I first run a local cluster with the updated config file, and test the flytesnacks advanced_composition examples to make sure it will actually offload the literal.

For the real CI test, I'll have to rely on the CI for this PR.

Setup process

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Mecoli1219 <[email protected]>
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.02%. Comparing base (e21a6ad) to head (c2d265b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6111      +/-   ##
==========================================
+ Coverage   36.98%   37.02%   +0.03%     
==========================================
  Files        1318     1310       -8     
  Lines      132449   131636     -813     
==========================================
- Hits        48984    48732     -252     
+ Misses      79212    78691     -521     
+ Partials     4253     4213      -40     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.03% <ø> (ø)
unittests-flytecopilot ?
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.85% <ø> (ø)
unittests-flytepropeller 42.60% <ø> (ø)
unittests-flytestdlib 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
@Mecoli1219 Mecoli1219 changed the title Add new sandbox-bundled-offloaded-functional-tests for offloading literals unit test [WIP] Add new sandbox-bundled-offloaded-functional-tests for offloading literals unit test Dec 17, 2024
Signed-off-by: Mecoli1219 <[email protected]>
@Mecoli1219 Mecoli1219 changed the title [WIP] Add new sandbox-bundled-offloaded-functional-tests for offloading literals unit test Add new sandbox-bundled-offloaded-functional-tests for offloading literals unit test Dec 17, 2024
@Mecoli1219
Copy link
Author

Mecoli1219 commented Dec 17, 2024

@pmahindrakar-oss this PR is ready to be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant