Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to release-v1.14 - Upstream ArrayNode DataMode + BindingData LiteralOffloadedMetadata idl changes (#6074) #6121

Merged
merged 1 commit into from
Dec 20, 2024

upstream ArrayNode DataMode + BindingData LiteralOffloadedMetadata id…

4b1d826
Select commit
Loading
Failed to load commit list.
Merged

backport to release-v1.14 - Upstream ArrayNode DataMode + BindingData LiteralOffloadedMetadata idl changes (#6074) #6121

upstream ArrayNode DataMode + BindingData LiteralOffloadedMetadata id…
4b1d826
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 20, 2024 in 1s

36.98% (-0.01%) compared to 8a5f54c

View this Pull Request on Codecov

36.98% (-0.01%) compared to 8a5f54c

Details

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (8a5f54c) to head (4b1d826).

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go 4.54% 21 Missing ⚠️
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 14.28% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-v1.14    #6121      +/-   ##
=================================================
- Coverage          36.98%   36.98%   -0.01%     
=================================================
  Files               1318     1318              
  Lines             132449   132475      +26     
=================================================
+ Hits               48990    48991       +1     
- Misses             79206    79231      +25     
  Partials            4253     4253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.